chore: Add CI check for formatting (#249)

* Apply suggestions from code review

Co-authored-by: seebees <[email protected]>

Author: lavaleri

.gitmodules

@@ -1,6 +1,6 @@
 [submodule "src/test/resources/aws-encryption-sdk-test-vectors"]
 	path = src/test/resources/aws-encryption-sdk-test-vectors
-	url = https://github.com/awslabs/private-aws-encryption-sdk-test-vectors-staging.git
+	url = https://github.com/awslabs/aws-encryption-sdk-test-vectors.git
 [submodule "aws-encryption-sdk-specification"]
 	path = aws-encryption-sdk-specification
-	url = https://github.com/awslabs/private-aws-encryption-sdk-specification-staging.git
+	url = https://github.com/awslabs/aws-encryption-sdk-specification.git

aws-encryption-sdk-specification

@@ -23,3 +23,8 @@ batch:
       env:
         env:
         image: aws/codebuild/amazonlinux2-x86_64-standard:3.0
+    - identifier: static_analysis
+      buildspec: codebuild/static-analysis.yml
+      env:
+        env:
+        image: aws/codebuild/amazonlinux2-x86_64-standard:3.0

buildspec.yml

@@ -4,6 +4,8 @@ phases:
   install:
     runtime-versions:
       nodejs: 12
+      java: corretto11
   build:
     commands:
+      - mvn com.coveo:fmt-maven-plugin:check
       - ./util/test-conditions.sh

codebuild/compliance.yml renamed to codebuild/static-analysis.yml

@@ -199,6 +199,16 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <plugin>
+                <groupId>com.coveo</groupId>
+                <artifactId>fmt-maven-plugin</artifactId>
+                <version>2.10</version>
+                <!-- Configure no goals. -->
+                <!--Until our CI builds no longer depend on Java 8, skip this during build.-->
+                <!--We instead manually check this in Java 11 environments to block builds, -->
+                <!--And additionally check this explicitly through Github Actions.-->
+            </plugin>
         </plugins>
     </build>
 

pom.xml

@@ -3,34 +3,34 @@
 
 package com.amazonaws.encryptionsdk;
 
-import com.amazonaws.encryptionsdk.CryptoAlgorithm;
-
 public enum CommitmentPolicy {
-    ForbidEncryptAllowDecrypt,
-    RequireEncryptAllowDecrypt,
-    RequireEncryptRequireDecrypt;
+  ForbidEncryptAllowDecrypt,
+  RequireEncryptAllowDecrypt,
+  RequireEncryptRequireDecrypt;
 
-    public boolean algorithmAllowedForEncrypt(CryptoAlgorithm algorithm) {
-        switch (this) {
-            case ForbidEncryptAllowDecrypt:
-                return !algorithm.isCommitting();
-            case RequireEncryptAllowDecrypt:
-            case RequireEncryptRequireDecrypt:
-                return algorithm.isCommitting();
-            default:
-                throw new UnsupportedOperationException("Support for commitment policy " + this + " not yet built.");
-        }
+  public boolean algorithmAllowedForEncrypt(CryptoAlgorithm algorithm) {
+    switch (this) {
+      case ForbidEncryptAllowDecrypt:
+        return !algorithm.isCommitting();
+      case RequireEncryptAllowDecrypt:
+      case RequireEncryptRequireDecrypt:
+        return algorithm.isCommitting();
+      default:
+        throw new UnsupportedOperationException(
+            "Support for commitment policy " + this + " not yet built.");
     }
+  }
 
-    public boolean algorithmAllowedForDecrypt(CryptoAlgorithm algorithm) {
-        switch (this) {
-            case ForbidEncryptAllowDecrypt:
-            case RequireEncryptAllowDecrypt:
-                return true;
-            case RequireEncryptRequireDecrypt:
-                return algorithm.isCommitting();
-            default:
-                throw new UnsupportedOperationException("Support for commitment policy " + this + " not yet built.");
-        }
+  public boolean algorithmAllowedForDecrypt(CryptoAlgorithm algorithm) {
+    switch (this) {
+      case ForbidEncryptAllowDecrypt:
+      case RequireEncryptAllowDecrypt:
+        return true;
+      case RequireEncryptRequireDecrypt:
+        return algorithm.isCommitting();
+      default:
+        throw new UnsupportedOperationException(
+            "Support for commitment policy " + this + " not yet built.");
     }
+  }
 }