Skip to content

fix: Undo squash merge, fix merge from mainline #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 6, 2020
Merged

Conversation

acioc
Copy link
Contributor

@acioc acioc commented Aug 6, 2020

Description of changes:
I did a squash merge on #209. This is bad since it means git (essentially) looses track of the actual commit history, preventing keyring from being merged into master in the future.

This no-op change fixes that.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mattsb42-aws and others added 11 commits May 20, 2020 18:16
This reverts commit 015fc3c, reversing
changes made to dcbc562.
*Description of changes:*

Updating Changelog for version 1.6.2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
…ws#191)

* fix: validate entire ciphertext has been processed before returning

* Updating changelog
This reverts commit bd4da5b, reversing
changes made to d88fe8b.
@acioc acioc requested a review from lavaleri August 6, 2020 20:30
Copy link
Contributor

@lavaleri lavaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down and verified on my fork that this cleanly can be rebased onto master

@acioc acioc merged commit 5a06dd6 into aws:keyring Aug 6, 2020
@acioc acioc deleted the keyring branch August 6, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants