Skip to content

fix: Merge mainline into keyrings, reverting the keyring reverts #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2020

Conversation

acioc
Copy link
Contributor

@acioc acioc commented Aug 5, 2020

Description of changes:
This change updates the keyring branch by merging mainline into keyrings. This change ensures that the keyrings branch is properly build on top of mainline's HEAD by reverting the reverts and updating the necessary build numbers.

By reverting the revert merge, the only changes are a result of:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mattsb42-aws and others added 8 commits May 20, 2020 18:16
This reverts commit 015fc3c, reversing
changes made to dcbc562.
*Description of changes:*

Updating Changelog for version 1.6.2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
…ws#191)

* fix: validate entire ciphertext has been processed before returning

* Updating changelog
This reverts commit bd4da5b, reversing
changes made to d88fe8b.
@acioc acioc requested a review from lavaleri August 5, 2020 23:56
Copy link
Contributor

@lavaleri lavaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the diff are as expected, but it looks like the build is broken.

@acioc acioc requested a review from lavaleri August 6, 2020 18:18
@acioc acioc merged commit 4442958 into aws:keyring Aug 6, 2020
@acioc acioc deleted the keyring branch August 6, 2020 20:13
acioc pushed a commit to acioc/aws-encryption-sdk-java that referenced this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants