Skip to content

fix hypothesis decimal strategy to fully filter out values that are not compatible with DYNAMODB_CONTEXT #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2018
Merged

fix hypothesis decimal strategy to fully filter out values that are not compatible with DYNAMODB_CONTEXT #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions test/functional/hypothesis_strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@
)


def _valid_ddb_number(value):
try:
DYNAMODB_CONTEXT.create_decimal(float(value))
except Exception:
return False
else:
return True


ddb_string = text(
min_size=1,
max_size=MAX_ITEM_BYTES
Expand All @@ -60,17 +69,17 @@

def _ddb_fraction_to_decimal(val):
"""Hypothesis does not support providing a custom Context, so working around that."""
return DYNAMODB_CONTEXT.create_decimal(Decimal(val.numerator) / Decimal(val.denominator))
return Decimal(val.numerator) / Decimal(val.denominator)


_ddb_positive_numbers = fractions(
min_value=POSITIVE_NUMBER_RANGE.min,
max_value=POSITIVE_NUMBER_RANGE.max
).map(_ddb_fraction_to_decimal)
).map(_ddb_fraction_to_decimal).filter(_valid_ddb_number)
_ddb_negative_numbers = fractions(
min_value=NEGATIVE_NUMBER_RANGE.min,
max_value=NEGATIVE_NUMBER_RANGE.max
).map(_ddb_fraction_to_decimal)
).map(_ddb_fraction_to_decimal).filter(_valid_ddb_number)

ddb_number = _ddb_negative_numbers | just(Decimal('0')) | _ddb_positive_numbers
ddb_number_set = sets(ddb_number, min_size=1)
Expand Down