fix hypothesis decimal strategy to fully filter out values that are not compatible with DYNAMODB_CONTEXT #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix hypothesis decimal strategy to fully filter out values that are not compatible with DYNAMODB_CONTEXT
This fixes an earlier misconception I had about when the decimal context is checked: it is checked when decimals are created (ex:
.create_decimal()), not when they operated on (ex: division).BLOCKED BY #21 and #22
NOTE
To ease parallelization of efforts, this PR is based on the
DELETE-4fork. Prior to looking over this PR, #21 and #22 should be merged tomasterand the base for this PR be changed tomaster.