Helper client code consolidation #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
praus
approved these changes
Apr 28, 2018
…ons to avoid the possibility of conflicts when curried functions are used elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the high level helper clients ended creating a lot of duplicate code. This takes all of that duplicate code, consolidates it into a few helper functions in
internal.util, and replaces the individual methods on the helper clients with partially curried calls to those helpers.BLOCKED BY #19
NOTE
To ease parallelization of efforts, this PR is based on the
DELETE-m-2fork. Prior to looking over this PR, #19 should be merged tomasterand the base for this PR be changed tomaster.