Linting take 1 #19
Merged
Linting take 1 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praus
reviewed
Apr 27, 2018
| verifier.verify(signature) | ||
| except Exception: | ||
| message = 'Unable to verify signature' | ||
| _LOGGER.exception(message) |
There was a problem hiding this comment.
Would it make sense to include the message (perhaps trimmed to a certain length) in the log to help with debugging?
There was a problem hiding this comment.
When the "exception" logging level is used in the scope of an except block, it automatically logs the full stacktrace of the exception that caused that block to be entered.
There was a problem hiding this comment.
But that stack trace wouldn't contain the message its signature that we failed to verify, right?
There was a problem hiding this comment.
That's a very good point. Opened #26 to track this, because I think that would be very useful.
praus
approved these changes
Apr 28, 2018
|
Apparently it also needed to be rebased after master was merged...ok then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code formatting/style/smell fixes identified by flake8/pylint.
BLOCKED BY #16
BLOCKED BY #18
NOTE
To ease parallelization of efforts, this PR is based on the
DELETE-m-1fork. Prior to looking over this PR, #16 and #18 should be merged tomasterand the base for this PR be changed tomaster.