Skip to content

test(parser): migrate to vitest & simplify structure #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Oct 23, 2024

Summary

Important

Please don't update/sync the branch until the PR is marked as ready for review

Changes

Please provide a summary of what's being changed

Note

This PR touches an unusually high number of files due to it refactoring both the test cases and files containing events for these tests.

This PR migrates the Parser utility tests to use Vitest, and while doing so, also streamlines the test structure to adhere the following guidelines:

  • Each test should import/read only files that are relevant to that test
  • When testing event payloads for AWS Services, focus on tests that verify the actual behavior of schemas and transforms (i.e. having two identical events for API Gateway where one differs only in the path field containing a trailing slash is useless since we don't validate/parse the path beyond ensuring it's a string).
  • Follow conventions set in the codebase and avoid type casts and suppressions unless strictly necessary

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3247


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Oct 23, 2024
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. parser This item relates to the Parser Utility tests PRs that add or change tests labels Oct 23, 2024
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Oct 23, 2024
Copy link

@dreamorosi
Copy link
Contributor Author

Partially superseded by #3299, plus future PRs.

@dreamorosi dreamorosi closed this Nov 7, 2024
@dreamorosi dreamorosi deleted the chore/parser_vitest branch January 28, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. parser This item relates to the Parser Utility size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: migrate test runner to vitest for parser package
1 participant