Skip to content

Maintenance: migrate test runner to vitest for parser package #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Oct 23, 2024 · 2 comments · Fixed by #3299
Closed
1 of 2 tasks

Maintenance: migrate test runner to vitest for parser package #3247

dreamorosi opened this issue Oct 23, 2024 · 2 comments · Fixed by #3299
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

To continue the migration from Jest to Vitest we need to move over the tests for the parser package to use the new test runner.

In doing so, we can also take the opportunity to streamline the test setup by avoiding loading all events for each test file/case, and remove unused/redundant test cases/events.

Why is this needed?

So that we can continue the migration as well as improve the overall performance and correctness of the tests, which currently rely on heavy I/O and might contain flawed assumptions/tests.

Which area does this relate to?

Parser

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility tests PRs that add or change tests labels Oct 23, 2024
@dreamorosi dreamorosi self-assigned this Oct 23, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Nov 8, 2024
Copy link
Contributor

This is now released under v2.11.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Nov 20, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility tests PRs that add or change tests
Projects
1 participant