Skip to content

chore(maintenance): exclude e2e tests from pre-push hook #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Oct 23, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR updates the pre-commit hook to include a filter for tests run via vitest. With the new filter only unit tests are run, thus excluding e2e tests.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3239


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team October 23, 2024 08:27
@dreamorosi dreamorosi requested a review from a team as a code owner October 23, 2024 08:27
@boring-cyborg boring-cyborg bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Oct 23, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Oct 23, 2024
Copy link

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Oct 23, 2024
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Oct 23, 2024
@dreamorosi dreamorosi self-assigned this Oct 23, 2024
@am29d am29d merged commit 6d94c14 into main Oct 23, 2024
29 checks passed
@am29d am29d deleted the chore/test_pre-push branch October 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: filter e2e tests in pre-push hook
2 participants