Skip to content

Maintenance: filter e2e tests in pre-push hook #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Oct 23, 2024 · 2 comments · Fixed by #3240
Closed
1 of 2 tasks

Maintenance: filter e2e tests in pre-push hook #3239

dreamorosi opened this issue Oct 23, 2024 · 2 comments · Fixed by #3240
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Oct 23, 2024

Summary

We use pre-push hooks to run quick tests on the code and give fast feedback to contributors. With the ongoing migration to vitest, we have added a vitest command to the hook, however in doing so we forgot to filter the tests. This causes both unit and e2e tests to run before each commit.

Why is this needed?

We should apply a filter and run only unit tests, so that we don't slow down the commit workflow too much. These tests will be run on the CI anyway.

Solution

No response

Acknowledgment

Future readers

@dreamorosi dreamorosi added automation This item relates to automation confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Oct 23, 2024
@dreamorosi dreamorosi self-assigned this Oct 23, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 23, 2024
Copy link
Contributor

This is now released under v2.10.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Oct 23, 2024
@dreamorosi dreamorosi moved this from Triage to Shipped in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant