Skip to content

test(batch): migrate unit tests to Vitest #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 19, 2024
Merged

test(batch): migrate unit tests to Vitest #2938

merged 11 commits into from
Aug 19, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR migrates the unit tests for the Batch Processing feature to use Vitest.

As part of this work, I have also:

  • Removed any Jest-specific configurations
  • Extracted the tests in CI as part of a new and improved matrix strategy test
  • Made coverage reporting opt-in during local tests for fast iteration
  • Changed the pre-push git hook to run tests only on files changed since branching out from main

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2937


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Aug 16, 2024
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels Aug 16, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Aug 16, 2024
@boring-cyborg boring-cyborg bot added the batch This item relates to the Batch Processing Utility label Aug 16, 2024
@dreamorosi dreamorosi changed the title tests(batch): migrate unit tests to Vitest test(batch): migrate unit tests to Vitest Aug 16, 2024
@dreamorosi dreamorosi marked this pull request as ready for review August 16, 2024 15:03
@dreamorosi dreamorosi requested a review from a team August 16, 2024 15:03
@dreamorosi dreamorosi requested a review from a team as a code owner August 16, 2024 15:03
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dreamorosi! Just small comments that you feel free to accept or not, they have no direct impact on the codebase or the proposal of this PR.

APPROVED!

Copy link

@dreamorosi dreamorosi merged commit 43bf71c into main Aug 19, 2024
12 checks passed
@dreamorosi dreamorosi deleted the chore/vitest_batch branch August 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation batch This item relates to the Batch Processing Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: migrate Batch Processing unit tests to vitest
3 participants