Skip to content

Maintenance: migrate Batch Processing unit tests to vitest #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Aug 16, 2024 · 2 comments · Fixed by #2938
Closed
1 of 2 tasks

Maintenance: migrate Batch Processing unit tests to vitest #2937

dreamorosi opened this issue Aug 16, 2024 · 2 comments · Fixed by #2938
Assignees
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

In #2935 we have added Vitest to the workspace, as part of this effort we should move the Batch Processing unit tests to use it.

The activity should be considered complete once the tests can be run: in 1/ CI environment, 2/ locally as a workspace, 3/ locally as standalone package, and 4/ locally in the pre-push commit hook.

As part of this work, we should also disable default coverage reporting.

Why is this needed?

So that we can continue the migration to Vitest.

Which area does this relate to?

Tests

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation tests PRs that add or change tests batch This item relates to the Batch Processing Utility labels Aug 16, 2024
@dreamorosi dreamorosi self-assigned this Aug 16, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Aug 16, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Aug 19, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Aug 19, 2024
Copy link
Contributor

This is now released under v2.8.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 16, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
Development

Successfully merging a pull request may close this issue.

1 participant