-
Notifications
You must be signed in to change notification settings - Fork 154
chore(maintenance): migrate metrics utility to biome #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry about this @daschaa - we need to improve our automation (I'm working on that on the side) to better detect linked issues. In the meantime, as a workaround - if you want to avoid the bot nagging you - you could edit/write the PR body with the issue number like here (I edited your comment to fix it) 😁 |
@dreamorosi I think with this regex the automation might work (at least i get good matches): \b\*{0,2}[iI]ssue [nN]umber\*{0,2}:\*{0,2}\s*(?<closingWord>closes?|closed|fix|fixes?|fixed|resolves?|resolved)*?\s*#*(?<issue>\d+)\b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work on this.
I have left only one other comment, but seems we are going in the right direction.
We'll have to do something about all the // biome-ignore lint/complexity/useLiteralKeys
but since it'll likely require a refactor of either the tests or the utility we will address this separately (same for Logger).
@daschaa - I just saw there are two Sonar findings. They are not areas you've touched, but the way the tool works is that it runs on files that were edited as part of the PR, and scans them. So that's why they're coming up now. |
I'll check them :) Sorry that I did not catch them earlier. I guess the checkmark icon in the sonar report just let's my brain ignore the report. 😄 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the work on this PR!
We're going to merge this for now, despite the addition of lint/complexity/useLiteralKeys
in the unit tests. We have another conversation ongoing in #2821 to make changes that we hope will allow us to remove most/all of the suppressions (thank you for opening the issue 😉).
Summary
Changes
Closes #2799
Issue number: closes #2799
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.