Skip to content

chore(maintenance): migrate snippets to biome #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jul 23, 2024

Summary

Changes

Adds biome to the snippets folder.

Issue number: closes #2792


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@daschaa daschaa requested a review from a team July 23, 2024 13:05
@daschaa daschaa requested a review from a team as a code owner July 23, 2024 13:05
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 23, 2024
@dreamorosi
Copy link
Contributor

Thank you for the PR!

I think this one will require a few more extra checks because some of the changes most likely affect the documentation. These code snippets are loaded in the docs, and now that some of the line numbers have changed the highlights in the snippets might have shifted.

For example, by removing a line in this file (which was the correct thing to do), the line numbers here have shifted.

I understand that this is a bit of tedious work, plus you'll have to run the docs locally to do it - so let me know how you'd like to proceed. I'm also happy to take over the PR if you want to do something more interesting like #2799.

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 23, 2024
@daschaa
Copy link
Contributor Author

daschaa commented Jul 23, 2024

@dreamorosi Interesting 💡 I was not aware of the connection with the line numbers. For me both is ok, I can also continue on fixing the references in the docs, as well as handing the PR over to you. I just do not want to create more work than help with this 😄

@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 23, 2024
@dreamorosi
Copy link
Contributor

I'm happy for you to do it, any help is more than appreciated!

I'd say give it a try and if you get bored or see that it takes too long than you'd like, feel free to tag me & I'll finish it - otherwise I trust that you'll do great

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jul 23, 2024
@daschaa
Copy link
Contributor Author

daschaa commented Jul 23, 2024

@dreamorosi I think I've catched everything :)

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left two minor comments - thanks for the work here 🎉

Copy link

@dreamorosi dreamorosi self-requested a review July 23, 2024 15:59
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help with this PR, highly appreciated!

@dreamorosi dreamorosi merged commit 4d44b91 into aws-powertools:main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add biome to project (snippets)
2 participants