-
Notifications
You must be signed in to change notification settings - Fork 154
chore(maintenance): migrate snippets to biome #2814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the PR! I think this one will require a few more extra checks because some of the changes most likely affect the documentation. These code snippets are loaded in the docs, and now that some of the line numbers have changed the highlights in the snippets might have shifted. For example, by removing a line in this file (which was the correct thing to do), the line numbers here have shifted. I understand that this is a bit of tedious work, plus you'll have to run the docs locally to do it - so let me know how you'd like to proceed. I'm also happy to take over the PR if you want to do something more interesting like #2799. |
This comment was marked as outdated.
This comment was marked as outdated.
@dreamorosi Interesting 💡 I was not aware of the connection with the line numbers. For me both is ok, I can also continue on fixing the references in the docs, as well as handing the PR over to you. I just do not want to create more work than help with this 😄 |
I'm happy for you to do it, any help is more than appreciated! I'd say give it a try and if you get bored or see that it takes too long than you'd like, feel free to tag me & I'll finish it - otherwise I trust that you'll do great |
@dreamorosi I think I've catched everything :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left two minor comments - thanks for the work here 🎉
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the help with this PR, highly appreciated!
Summary
Changes
Adds biome to the snippets folder.
Issue number: closes #2792
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.