Skip to content

chore(docs): fix middy v4 version support #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Apr 2, 2024

Description of your changes

This PR changes the wording for the middyjs support version to up to v4.x and defaults to v4.x.

Related issues, RFCs

Issue number: closes #2300

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team April 2, 2024 11:29
@am29d am29d requested a review from a team as a code owner April 2, 2024 11:29
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Apr 2, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Apr 2, 2024
@am29d am29d self-assigned this Apr 2, 2024
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dreamorosi dreamorosi merged commit 92193e7 into main Apr 2, 2024
@dreamorosi dreamorosi deleted the docs/fix-middy-3x branch April 2, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Idempotency docs say only Middy v3.x is supported
2 participants