Skip to content

Docs: Idempotency docs say only Middy v3.x is supported #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
buggy opened this issue Apr 2, 2024 · 4 comments · Fixed by #2301
Closed
1 task done

Docs: Idempotency docs say only Middy v3.x is supported #2300

buggy opened this issue Apr 2, 2024 · 4 comments · Fixed by #2301
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@buggy
Copy link

buggy commented Apr 2, 2024

What were you searching in the docs?

I was reading the whole Powertools for AWS Lambda (Typescript) docs.

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/typescript/latest/utilities/idempotency/#makehandleridempotent-middy-middleware

How can we improve?

Immediately below the heading "MakeHandlerIdempotent Middy middleware" there is a "A note about Middy" which says that only v3.x is support. Other parts of the documentation say v4.x

Got a suggestion in mind?

Change v3.x to v4.x

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@buggy buggy added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Apr 2, 2024
@am29d
Copy link
Contributor

am29d commented Apr 2, 2024

Hey @buggy , thanks for dropping the issue that we have missed during the upgrade to v2. Dropping the fix asap.

@am29d am29d added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Apr 2, 2024
@am29d am29d self-assigned this Apr 2, 2024
@am29d am29d moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Apr 2, 2024
@am29d
Copy link
Contributor

am29d commented Apr 2, 2024

Found additional inconsistencies:

Copy link
Contributor

github-actions bot commented Apr 2, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Apr 2, 2024
Copy link
Contributor

This is now released under v2.0.4 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Apr 10, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

2 participants