Skip to content

chore(maintenance): add core team to code owners #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR adds the @aws-powertools/core GitHub team to the CODEOWNERS file so that if one of the members of that team reviews a PR, the requirement of having at least one approver is fulfilled.

This is not the case today, and this essentially equates to requiring multiple reviews which is not what we want at this stage.

Related issues, RFCs

Issue number: closes #2098

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Feb 20, 2024
@dreamorosi dreamorosi requested a review from a team February 20, 2024 10:32
@boring-cyborg boring-cyborg bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 20, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 20, 2024
@dreamorosi dreamorosi requested a review from sthulb February 20, 2024 10:32
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi
Copy link
Contributor Author

I already talked with Governance offline and @sthulb is ok with the proposed change. Merging.

@dreamorosi dreamorosi merged commit ecd63cc into main Feb 20, 2024
@dreamorosi dreamorosi deleted the chore/update_code_owners branch February 20, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add Powertools Core team to CODEOWNERS
2 participants