Skip to content

Maintenance: add Powertools Core team to CODEOWNERS #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Feb 20, 2024 · 2 comments · Fixed by #2099
Closed
1 of 2 tasks

Maintenance: add Powertools Core team to CODEOWNERS #2098

dreamorosi opened this issue Feb 20, 2024 · 2 comments · Fixed by #2099
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

In the past few weeks we have strengthened our branch protection so that all PRs must have at least 1 approval from the team of maintainers. At the moment the pool of approvers is only the @aws-powertools/lambda-typescript-core team, however in the past few weeks we have had multiple reviews from members of the @aws-powertools/core team as well.

After discussing with @sthulb, we should add the second team to the pool of reviewer.

Why is this needed?

So that we can merge PRs more quickly when we receive reviews from the core team and require double-reviews.

Which area does this relate to?

Governance

Solution

Add the core team to the CODEOWNERS file.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Feb 20, 2024
@dreamorosi dreamorosi self-assigned this Feb 20, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Feb 20, 2024
Copy link
Contributor

This is now released under v1.18.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Feb 20, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant