You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dreamorosi opened this issue
Feb 20, 2024
· 2 comments
· Fixed by #2099
Assignees
Labels
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
In the past few weeks we have strengthened our branch protection so that all PRs must have at least 1 approval from the team of maintainers. At the moment the pool of approvers is only the @aws-powertools/lambda-typescript-core team, however in the past few weeks we have had multiple reviews from members of the @aws-powertools/core team as well.
After discussing with @sthulb, we should add the second team to the pool of reviewer.
Why is this needed?
So that we can merge PRs more quickly when we receive reviews from the core team and require double-reviews.
Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered:
dreamorosi
added
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
confirmed
The scope is clear, ready for implementation
labels
Feb 20, 2024
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Summary
In the past few weeks we have strengthened our branch protection so that all PRs must have at least 1 approval from the team of maintainers. At the moment the pool of approvers is only the
@aws-powertools/lambda-typescript-core
team, however in the past few weeks we have had multiple reviews from members of the@aws-powertools/core
team as well.After discussing with @sthulb, we should add the second team to the pool of reviewer.
Why is this needed?
So that we can merge PRs more quickly when we receive reviews from the core team and require double-reviews.
Which area does this relate to?
Governance
Solution
Add the core team to the
CODEOWNERS
file.Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: