Skip to content

chore(ci): restore dependencies & fix e2e tests #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, a series of previous PRs that removed dependencies from the project caused the unintended side effect of breaking the e2e tests. This PR temporarily reintroduces these dependencies so that we can continue running our tests while we work on looking for alternatives.

Related issues, RFCs

Issue number: #1614

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jul 15, 2023
@dreamorosi dreamorosi requested a review from a team July 15, 2023 00:55
@dreamorosi dreamorosi linked an issue Jul 15, 2023 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jul 15, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 15, 2023
@dreamorosi
Copy link
Contributor Author

@dreamorosi dreamorosi merged commit a57dc11 into main Jul 15, 2023
@dreamorosi dreamorosi deleted the 1614-maintenance-revert-changes-to-dependencies-fix-e2e-tests branch July 15, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: revert changes to dependencies & fix e2e tests
1 participant