Skip to content

Maintenance: revert changes to dependencies & fix e2e tests #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jul 15, 2023 · 2 comments · Fixed by #1615
Closed
1 of 2 tasks

Maintenance: revert changes to dependencies & fix e2e tests #1614

dreamorosi opened this issue Jul 15, 2023 · 2 comments · Fixed by #1615
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Jul 15, 2023

Summary

In #1611, #1612, and #1613 we removed some dependencies from the package-lock.json and package.json files in an effort to remove deprecated dependencies. While removing them, the team assumed they weren't being used in the project, however this was a mistake as at least one of the dependencies (http-proxy) is used by an internal module of CDK, which is used to run our integration/e2e tests.

After merging the PR I ran our test suite, which resulted in failures across the board: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5558549980/jobs/10153776837

While we continue looking for alternatives (#1314), we need to restore the dependencies.

Why is this needed?

So that we are able to continue running our integration tests while we look for an alternative to these dependencies.

Which area does this relate to?

Tests

Solution

Restore the content of the package.json & package-lock.json to the one found in this commit.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation tests PRs that add or change tests labels Jul 15, 2023
@dreamorosi dreamorosi self-assigned this Jul 15, 2023
@dreamorosi dreamorosi linked a pull request Jul 15, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 15, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jul 15, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jul 15, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jul 15, 2023
@am29d
Copy link
Contributor

am29d commented Jul 15, 2023

that’s odd, I ran the tests before the merge and they passed. Will run the r2-d2 tests next time before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
Development

Successfully merging a pull request may close this issue.

2 participants