You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dreamorosi opened this issue
Jul 15, 2023
· 2 comments
· Fixed by #1615
Assignees
Labels
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change tests
In #1611, #1612, and #1613 we removed some dependencies from the package-lock.json and package.json files in an effort to remove deprecated dependencies. While removing them, the team assumed they weren't being used in the project, however this was a mistake as at least one of the dependencies (http-proxy) is used by an internal module of CDK, which is used to run our integration/e2e tests.
Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered:
dreamorosi
added
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
confirmed
The scope is clear, ready for implementation
tests
PRs that add or change tests
labels
Jul 15, 2023
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change tests
Summary
In #1611, #1612, and #1613 we removed some dependencies from the
package-lock.json
andpackage.json
files in an effort to remove deprecated dependencies. While removing them, the team assumed they weren't being used in the project, however this was a mistake as at least one of the dependencies (http-proxy
) is used by an internal module of CDK, which is used to run our integration/e2e tests.After merging the PR I ran our test suite, which resulted in failures across the board: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5558549980/jobs/10153776837
While we continue looking for alternatives (#1314), we need to restore the dependencies.
Why is this needed?
So that we are able to continue running our integration tests while we look for an alternative to these dependencies.
Which area does this relate to?
Tests
Solution
Restore the content of the
package.json
&package-lock.json
to the one found in this commit.Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: