Skip to content

chore(maintenance): remove proxy-agent from dependencies #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jul 14, 2023

Description of your changes

This PR removes proxy-agent from our dependencies, because we don't use it. I have ran unit and e2e tests and they passed.

Related issues, RFCs

Issue number: closes #1610

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team July 14, 2023 18:10
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Jul 14, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 14, 2023
@am29d am29d requested review from dreamorosi and removed request for a team July 14, 2023 18:10
@am29d am29d self-assigned this Jul 14, 2023
@am29d am29d merged commit fa3e1a1 into main Jul 14, 2023
@am29d am29d deleted the 1609-remove-unused-proxy-agent branch July 14, 2023 19:16
@am29d am29d restored the 1609-remove-unused-proxy-agent branch July 14, 2023 19:20
am29d added a commit that referenced this pull request Jul 14, 2023
@dreamorosi
Copy link
Contributor

I just ran the e2e tests on main and they're failing because of that missing dependency: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5558549980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: remove proxy-agent from dependencies
2 participants