Skip to content

chore(docs): fix workflow secrets #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023
Merged

chore(docs): fix workflow secrets #1470

merged 1 commit into from
May 19, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented May 19, 2023

Description of your changes

Adds fix for S3 Docs. The on_docs_push workflow has an unknown issue, but passing the secrets directly resolves it.

Related issues, RFCs

Issue number: #1468

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label May 19, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label May 19, 2023
@github-actions github-actions bot added bug Something isn't working labels May 19, 2023
@dreamorosi dreamorosi changed the title fix(docs): fix for docs chore(docs): fix workflow secrets May 19, 2023
@dreamorosi dreamorosi merged commit d4ae762 into main May 19, 2023
@dreamorosi dreamorosi deleted the s3-docs-fix branch May 19, 2023 14:49
@dreamorosi dreamorosi removed the bug Something isn't working label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants