chore(ci): add step to publish docs to S3 #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
dreamorosi
reviewed
May 18, 2023
1 task
dreamorosi
approved these changes
May 18, 2023
|
@am29d, can you please check if the steps added by Simon would publish the docs & api versions correctly? I think yes, but I'd appreciate a second pair of eyes. |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
sthulb
added a commit
that referenced
this pull request
May 19, 2023
* add required steps and permissions * update permissions for doc launching * adds environment to the workflow file * Update .github/workflows/reusable-publish-docs.yml --------- Co-authored-by: Andrea Amorosi <[email protected]>
9 tasks
github-actions
bot
added
the
pending-release
dreamorosi
removed
the
pending-release
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a new storage location for docs when they’re generated. Three of the files changed are for permissions changes to ensure that the
id-tokenhas write privileges. This PR uses a new environment (Docs) that has already been created in the repo settings.Related issues, RFCs
Issue number: #1467
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.