Skip to content

build(layers): aligned aws cdk versions in layer-publisher to main workspace #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in #1227, due to a version mismatch between the aws-cdk-lib dependencies in the layer-publisher and main workspace the integration tests were failing.

The linked issue contains a more exhaustive description of the issue, but the TL;DR; is that if the dependency version used in the two workspaces is not aligned, the integration tests for the layer publisher module will fail.

This PR realigns the version as a stop-gap solution. A proper long term fix is tracked in #1226 and will be proposed as a separate PR in the near future.

How to verify this change

See result of integration test run here (successful): https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3893918816

Related issues, RFCs

Issue number: #1227

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: aws-cdk dependencies in layers-publisher out of sync with main workspace
1 participant