Skip to content

Maintenance: aws-cdk dependencies in layers-publisher out of sync with main workspace #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 11, 2023 · 1 comment · Fixed by #1228
Closed
1 of 2 tasks
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone

Comments

@dreamorosi
Copy link
Contributor

Summary

The layer-publisher folder contains the utilities and tests used to publish AWS Lambda Layers for Powertools. Currently the folder has its own dependency tree and is disconnected from the main one.

We need to realign the versions of the dependencies related to AWS CDK present in the layer-publisher/package-lock.json file with the ones in package-lock.json.

Why is this needed?

Because layer-publisher uses some utilities from packages/commons and they both import modules from aws-cdk-lib. If the two versions don't match (or at least are not close enough), the interfaces/prototypes of the imported classes will be different thus causing errors.

This happened in this e2e test run: https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3893483365

Notice in the errors that the App class from aws-cdk-lib appears to have different implementation/interface between the two imports.

Which area does this relate to?

Automation, Other

Solution

A short term solution that somewhat manually realigns the two dependency trees is proposed in the linked PR. The long term solution would be to make the layers-publisher part of the main npm workspace, an activity that is tracked in #1226.

Acknowledgment

@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jan 11, 2023
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Jan 11, 2023
@dreamorosi dreamorosi self-assigned this Jan 11, 2023
@dreamorosi dreamorosi added this to the Lambda layer milestone Jan 11, 2023
@dreamorosi dreamorosi added the automation This item relates to automation label Jan 11, 2023
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Jan 11, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Jan 11, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Jan 11, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
1 participant