Maintenance: aws-cdk
dependencies in layers-publisher
out of sync with main workspace
#1227
Closed
1 of 2 tasks
Labels
automation
This item relates to automation
completed
This item is complete and has been merged/shipped
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone
Summary
The
layer-publisher
folder contains the utilities and tests used to publish AWS Lambda Layers for Powertools. Currently the folder has its own dependency tree and is disconnected from the main one.We need to realign the versions of the dependencies related to AWS CDK present in the
layer-publisher/package-lock.json
file with the ones inpackage-lock.json
.Why is this needed?
Because
layer-publisher
uses some utilities frompackages/commons
and they both import modules fromaws-cdk-lib
. If the two versions don't match (or at least are not close enough), the interfaces/prototypes of the imported classes will be different thus causing errors.This happened in this e2e test run: https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3893483365
Notice in the errors that the
App
class fromaws-cdk-lib
appears to have different implementation/interface between the two imports.Which area does this relate to?
Automation, Other
Solution
A short term solution that somewhat manually realigns the two dependency trees is proposed in the linked PR. The long term solution would be to make the
layers-publisher
part of the main npm workspace, an activity that is tracked in #1226.Acknowledgment
The text was updated successfully, but these errors were encountered: