refactor(typing): enable TCH, UP and FA100 ruff rules #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
commons
documentation
pull-request-size
bot
added
the
size/L
2 tasks
ericbn
commented
Aug 19, 2024
ericbn
commented
Aug 19, 2024
2 tasks
github-actions
bot
added
enhancement
and removed
documentation
boring-cyborg
bot
added
the
documentation
|
ericbn
commented
Aug 19, 2024
github-actions
bot
removed
the
documentation
There was a problem hiding this comment.
Hi @ericbn! Just a few comments that you probably won't need to do anything about.
I'm just waiting for the CI to turn green to approve this PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #5016
Summary
Changes
Enable TCH, UP and FA100 rules in the Ruff linter.
User experience
Discussed in #4607
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.