Skip to content

Technical Debt: Enable TCH, UP and FA100 rules in the Ruff linter #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
leandrodamascena opened this issue Aug 19, 2024 · 6 comments · Fixed by #5017
Closed
1 of 2 tasks

Technical Debt: Enable TCH, UP and FA100 rules in the Ruff linter #5016

leandrodamascena opened this issue Aug 19, 2024 · 6 comments · Fixed by #5017
Assignees
@leandrodamascena
Labels
tech-debt Technical Debt tasks typing Static typing definition related issues (mypy, pyright, etc.)
Milestone
Powertools v3 (pr...

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

Reference: #4607

We have refactored our codebase to ensure we are following best practices defined by the PEP documents and implemented by Ruff.

This implementation should not consider the example/tests folder and if necessary, these folders should be added as an exception in the lint.per-file-ignores section in the ruff.toml file.

Which area does this relate to?

Automation

Suggestion

No response

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks labels Aug 19, 2024
@leandrodamascena leandrodamascena self-assigned this Aug 19, 2024
@leandrodamascena leandrodamascena added typing Static typing definition related issues (mypy, pyright, etc.) and removed triage Pending triage from maintainers labels Aug 19, 2024
@leandrodamascena leandrodamascena moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Aug 19, 2024
@leandrodamascena
Copy link
Contributor Author

Hey @ericbn! I'm working on that and will submit a PR to review, ok?

@ericbn
Copy link
Contributor

ericbn commented Aug 19, 2024

I have these changes ready already and I can open as PR right away if that sounds good to you.

@leandrodamascena
Copy link
Contributor Author

I have these changes ready already and I can open as PR right away if that sounds good to you.

Please go ahead!!! 😊😊

@ericbn ericbn mentioned this issue Aug 19, 2024
Merged
7 tasks
@ericbn
Copy link
Contributor

ericbn commented Aug 19, 2024

Cool! Just opened #5017.

@leandrodamascena leandrodamascena linked a pull request Aug 19, 2024 that will close this issue
refactor(typing): enable TCH, UP and FA100 ruff rules #5017
Merged
7 tasks
@leandrodamascena
Copy link
Contributor Author

Closing as completed!

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
tech-debt Technical Debt tasks typing Static typing definition related issues (mypy, pyright, etc.)
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
Powertools v3 (priority)
Development

Successfully merging a pull request may close this issue.

refactor(typing): enable TCH, UP and FA100 ruff rules ericbn/powertools-lambda-python
2 participants
@ericbn @leandrodamascena