-
Notifications
You must be signed in to change notification settings - Fork 421
feat(parser): infer model from type hint #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): infer model from type hint #3181
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
As |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Tom01098! We really like PR like this, when we can improve the developer experience with simple but useful ideas. Thanks for working on this.
I left some comments and would like to hear your opinion.
Hi @Tom01098! We are planning to release a version on Friday and would like to include it. Do you think I can fix a few small things and get this PR ready for merging? Thanks |
Hi @leandrodamascena! Feel free to sort this out, I was going to do it this weekend but happy to get it through to the next release. Thanks! |
You've done most of the work and we only need to fix two small things. I will push the commit and we will mention you in the Release Notes! Thank you so much, improving the development experience by removing boilerplate code is something we work hard every day. |
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3181 +/- ##
========================================
Coverage 95.96% 95.96%
========================================
Files 195 195
Lines 8381 8386 +5
Branches 1562 1563 +1
========================================
+ Hits 8043 8048 +5
Misses 276 276
Partials 62 62
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed!
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #3173
Summary
Changes
Made
model
optional inevent_parser
.User experience
Users can now elide providing the
model
argument.Before
After
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.