-
Notifications
You must be signed in to change notification settings - Fork 421
Feature request: Remove duplication of type when parsing event #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening your first issue here! We'll come back to you as soon as we can. |
Great idea @Tom01098 -- please feel free to send a PR as you suggested 🫶 It's still within our Progressive tenet -- explicit for most of us, and implicit via type hint for the cutting edge. Feel free to ping on Discord or here if we can help with anything |
|
Use case
When using the
event_parser
decorator to parse theevent
, the type will be duplicated if using type hints as a best practice.Solution/User Experience
I am proposing that we can drop the
model
parameter as we can infer it fromevent
s type hint.I am very happy to contribute this feature request, it should be very small and is totally backwards-compatible (
model
will still be accepted and chosen before type hints are inspected).Alternative solutions
Acknowledgment
The text was updated successfully, but these errors were encountered: