feat: Add AppConfig provider to parameters module #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1104 +/- ##
============================================
- Coverage 71.20% 71.08% -0.12%
- Complexity 535 541 +6
============================================
Files 71 72 +1
Lines 2240 2314 +74
Branches 240 249 +9
============================================
+ Hits 1595 1645 +50
- Misses 532 550 +18
- Partials 113 119 +6
☔ View full report in Codecov by Sentry. |
scottgerring
changed the title
jeromevdl
reviewed
Jun 2, 2023
...ools-e2e-tests/src/test/java/software/amazon/lambda/powertools/testutils/Infrastructure.java
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Show resolved
Hide resolved
Co-authored-by: Jérôme Van Der Linden <[email protected]>
…ertools/parameters/AppConfigProvider.java Co-authored-by: Jérôme Van Der Linden <[email protected]>
…ig' into feat-params-appconfig
jeromevdl
reviewed
Jun 13, 2023
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
|
I reckon this is good to go. Happy to approve @jeromevdl ? |
|
@msailes do you mind giving this a quick skim over? |
kozub
reviewed
Jun 20, 2023
...e2e-tests/handlers/parameters/src/main/java/software/amazon/lambda/powertools/e2e/Input.java
Outdated
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Show resolved
Hide resolved
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
...meters/src/test/java/software/amazon/lambda/powertools/parameters/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
…ig' into feat-params-appconfig
jeromevdl
approved these changes
Jun 21, 2023
jeromevdl
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1084
Description of changes:
Implements a parameters provider that uses AWS' AppConfig service as the backing store.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.