Skip to content

Add AppConfig provider for the parameters module #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromevdl opened this issue Mar 10, 2023 · 4 comments
Closed

Add AppConfig provider for the parameters module #1084

jeromevdl opened this issue Mar 10, 2023 · 4 comments
Assignees
Labels
feature-parity Feature parity with python version

Comments

@jeromevdl
Copy link
Contributor

To fill the gap with Powertools for Python, we should add AppConfig as a source for parameters.

Python version: https://awslabs.github.io/aws-lambda-powertools-python/2.9.1/utilities/parameters/#appconfigprovider

In order to provide this, we can implement a new Provider (AppConfigProvider) extending the BaseProvider we already have.

Note that adding this implies to add a dependency to the AppConfig SDK, which will make the module heavier. Thinking about a v2, we could permit to choose only the required provider (and dependencies) to limit the size of the module.

Probably in v2, if we separate parameters in submodules and have one for AppConfig, it could also be used for Feature Flag module (if reuse is possible and makes sense).

@jeromevdl jeromevdl added good-first-issue Good for newcomers feature-parity Feature parity with python version labels Mar 10, 2023
@scottgerring scottgerring self-assigned this Mar 16, 2023
@scottgerring
Copy link
Contributor

I've started #1083 and it looks like it'll save time to do both of these once, so i'll pick this up too.

@scottgerring
Copy link
Contributor

#1083 has been implemented. I will use the experience there to do this one as a separate PR now.

@scottgerring scottgerring added status/staged-major-release This change will go with the next major release and removed good-first-issue Good for newcomers labels Jun 21, 2023
@scottgerring
Copy link
Contributor

Merged; waiting for release.

@scottgerring scottgerring added status/staged-next-release and removed status/staged-major-release This change will go with the next major release labels Jun 29, 2023
@scottgerring
Copy link
Contributor

Released in 1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-parity Feature parity with python version
Projects
None yet
Development

No branches or pull requests

2 participants