Skip to content

Pass cliConfigPath to Language Server #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2021
Merged

Pass cliConfigPath to Language Server #25

merged 1 commit into from
May 5, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented May 5, 2021

Motivation

Language Server now requires an additional cliConfigPath

Change description

  • parse the cliConfigPath from parameters and pass it to the executable as a flag

Additional Notes

Required by ATL-1247

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • History is clean, commit messages are meaningful.

@fstasi fstasi requested a review from silvanocerza May 5, 2021 09:15
@fstasi fstasi mentioned this pull request May 5, 2021
Merged
3 tasks
@fstasi fstasi merged commit 13e711c into main May 5, 2021
@per1234 per1234 deleted the language-server-cli-config branch September 28, 2021 06:52
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fstasi @silvanocerza @per1234