Skip to content

[ATL-1247] Language Server now requires an additional cliConfigPath #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

[ATL-1247] Language Server now requires an additional cliConfigPath #354

merged 1 commit into from
May 11, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented May 5, 2021 •
edited
Loading

Motivation

Language server: pass a flag to set arduino-cli config file

Change description

  • get the cli config path
  • pass it to the language server

How To Test

In order to test this PR you have to manually install the updated vscode-arduino-tools plugin (recommended) or wait for it to be built in the nightly

Manual Test

So you are bold enough to try with the manual test, aren't you?
-> Unzip the following file in the .plugins directory of arduino-ide, replacing the existing vscode-arduino-tools dir (see screenshot)
vscode-arduino-tools.zip

image

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • History is clean, commit messages are meaningful.

@fstasi fstasi requested a review from silvanocerza May 5, 2021 09:40
silvanocerza
silvanocerza approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. 👍

ubidefeo
ubidefeo approved these changes May 11, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@fstasi fstasi merged commit 852bf9b into main May 11, 2021
@fstasi fstasi deleted the atl-1247--pass-language-server-config branch May 11, 2021 11:50
@per1234 per1234 added topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server labels Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees

@ubidefeo ubidefeo

Labels
topic: code Related to content of the project itself topic: language server Related to the Arduino Language Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fstasi @ubidefeo @silvanocerza @per1234