Sanitize git log output used in for Go release template #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go release system uses a `git log` command to determine the commit in order to populate the output of the application's `version` command. The expected output of the command is solely the short hash. With the previous command, that expectation was not realized under the following conditions: - The `log.showSignature` Git configuration option is set to true. - The commit being built was signed (as is always the case when a commit is made via the GitHub web interface). In this case, the signing information is shown in addition to the hash, breaking the build system.
per1234
added
type: imperfection
rsora
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sync of a downstream fix: arduino/arduino-cli#1344
The Go release system uses a
git logcommand to determine the commit in order to populate theoutput of the application's
versioncommand. The expected output of the command is solely the short hash. With theprevious command, that expectation was not realized under the following conditions:
log.showSignatureGit configuration option is set to true.In this case, the signing information is shown in addition to the hash, breaking the build system.