task: Sanitize git log output when building COMMIT variable #1344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
Taskfile.yml
.If the user has configured
git
to always show commit signatures ingit log
, thentask
could emit malformed arguments to thego build
command generated fromtask build
.For example, in my
git
config file:And then running
task build
you will see rather confusing output:This PR adds an argument to suppress signature output from the offending
git log
command inTaskfile.yml
.Now running
task build
completes as expected:arduino-cli $ task build task: [build] go build -v -ldflags ' -X github.com/arduino/arduino-cli/version.versionString=git-snapshot -X github.com/arduino/arduino-cli/version.commit=892a2ba1 -X github.com/arduino/arduino-cli/version.date=2021-07-01T23:10:16Z ' arduino-cli $ ./arduino-cli version arduino-cli alpha Version: git-snapshot Commit: 892a2ba1 Date: 2021-07-01T23:10:16Z