keyboardBegin.adoc: add Portuguese keyboard layout #913
Conversation
|
Hi @edgar-bonet , and apologies for the incredibly late response here. This looks great, and the I saw in the Keyboard library that Hungarian support was added as well (arduino-libraries/Keyboard#84), so I made a suggestion that you also include this. |
|
Hi @karlsoderby, and thanks for the heads-up! I committed your suggestion, 👍 but then re-sorted the layouts to keep them in alphabetical order. I also removed the draft status, as it was meant to last only until release 1.0.5. Should I squash the three commits together? |
|
Ah thank you, I did not consider alphabetical order. Yes please do so, and we can merge this PR! Thanks a lot! |
Version 1.0.5 of the Keyboard library added the Portuguese and the Hungarian keyboard layouts. Update the documentation of Keyboard.begin() accordingly. Co-authored-by: Karl Söderby <[email protected]>
edgar-bonet
force-pushed
the
keyboard-pt
branch
from
d8505bf to
00a094c
Compare
|
@karlsoderby: OK, done. I squashed the three commits together while rebasing on top of master. |
|
Fantastic. Thank you @edgar-bonet ! |
Since commit cbee538 (pull request #77, merged on 2023-02-20), the Keyboard library supports the Portuguese keyboard layout. This pull request adds the layout to the documentation of
Keyboard.begin().This is a draft pull request. Since the latest release of the Keyboard library (1.0.4) does not include the Portuguese layout, this layout is only available on master. I will remove the “draft” status once the layout is available in a released version. Note that the commit message mentions release 1.0.5, which is the expected version number of the next release. If the version number turns out to be different (1.1.0 maybe?), I will amend the commit message.