You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Board,examples/Serial<br>flash,%,examples/Serial<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A
arduino:samd:mkrzero,0,0.0,0,0.0
The reason will be displayed to describe this comment to others. Learn more.
Hello, thanks for this pull request! It's nice to see people contributing to the internationalization of this library. I am not a maintainer, but I have a few suggestions below.
Would you fancy becoming it 🙂 ? I wanted to ask you for some time, feel free to say no if you see it as a burden but I'd really love to give you the freedom to apply changes and speedup the whole process 😉
Note that I have only one Arduino on which I can test this library: an Arduino Micro. I thus cannot check cross-architecture compatibility. Is this a problem?
I'd really love to give you the freedom to apply changes and speedup the whole process 😉
What would be the recommended way of handling the pull request then? Wait for the author to amend or respond to the feedback? Or push my recommended changes on top of his commit and then merge?
What would be the recommended way of handling the pull request then? Wait for the author to amend or respond to the feedback? Or push my recommended changes on top of his commit and then merge?
Board,examples/Serial<br>flash,%,examples/Serial<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A
arduino:samd:mkrzero,0,0.0,0,0.0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per1234
added
type: enhancement
Title says everything