Skip to content

Update repositories.txt #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update repositories.txt #4748

merged 1 commit into from
Jul 4, 2024

Conversation

microbotsio
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

ERROR: Arduino Lint found errors with https://github.com/microbotsio/DriveCell:

Linting library in DriveCell
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (DriveCell.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) DriveCell.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           DriveCell/DriveCell/examples/CodeCell_ESP32/BrushedMotors_example                      
           DriveCell/DriveCell/examples/CodeCell_ESP32/CoilPad_example                            
           DriveCell/DriveCell/examples/CodeCell_ESP32/FlatFlap_example                           
           DriveCell/DriveCell/examples/CodeCell_ESP32/LED_example                                
           DriveCell/DriveCell/examples/Other Arduino/CoilPad_example                             
           DriveCell/DriveCell/examples/Other Arduino/FlatFlap_Example                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @microbotsio
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@microbotsio
Copy link
Contributor Author

DriveCell.h is included in the directory

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @microbotsio. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/microbotsio/DriveCell/tree/1.1.0

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 4, 2024
@per1234 per1234 mentioned this pull request Jul 4, 2024
@microbotsio
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Jul 4, 2024
@github-actions github-actions bot merged commit 86ad863 into arduino:main Jul 4, 2024
12 checks passed
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/microbotsio/DriveCell/

github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants