Skip to content

Update repositories.txt #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update repositories.txt #4740

wants to merge 1 commit into from

Conversation

microbotsio
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

A problem was found with your submission https://github.com/microbotsio/DriveCell

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @microbotsio
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@microbotsio microbotsio closed this Jul 3, 2024
@microbotsio microbotsio reopened this Jul 3, 2024
@microbotsio microbotsio closed this Jul 3, 2024
@microbotsio microbotsio reopened this Jul 3, 2024
@microbotsio microbotsio closed this Jul 3, 2024
@microbotsio microbotsio reopened this Jul 3, 2024
@per1234 per1234 mentioned this pull request Jul 3, 2024
@per1234
Copy link
Contributor

per1234 commented Jul 3, 2024

@ArduinoBot please check it again.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

ERROR: Arduino Lint found errors with https://github.com/microbotsio/DriveCell:

Linting library in DriveCell
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification
       (Rule LS001)                                                           
INFO: No header file found matching library name (DriveCell.h). Best practices are for primary header filename to match 
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) DriveCell.h not found in library.                           
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           DriveCell/DriveCell/examples/CodeCell_ESP32/BrushedMotors_example                      
           DriveCell/DriveCell/examples/CodeCell_ESP32/CoilPad_example                            
           DriveCell/DriveCell/examples/CodeCell_ESP32/FlatFlap_example                           
           DriveCell/DriveCell/examples/CodeCell_ESP32/LED_example                                
           DriveCell/DriveCell/examples/Other Arduino/CoilPad_example                             
           DriveCell/DriveCell/examples/Other Arduino/FlatFlap_Example                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @microbotsio
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello . Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

Linting library in DriveCell
ERROR: Path does not contain a valid Arduino library.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Correct the structure of the library files in your repository so that they are compliant with the Arduino Library Specification:
    https://arduino.github.io/arduino-cli/latest/library-specification/#layout-of-folders-and-files
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 3, 2024
@microbotsio microbotsio closed this Jul 4, 2024
@microbotsio microbotsio reopened this Jul 4, 2024
@per1234 per1234 self-assigned this Jul 4, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as duplicate of #4748

@microbotsio you are behaving disrespectfully by ignoring my comments. This is not a good look for someone who is engaged in a business in a technical field. I recommend you start to behave in a more professional manner in your technical work.

@per1234 per1234 closed this Jul 4, 2024
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: waiting for information More information must be provided before work can proceed labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants