Skip to content

Update URL of "KONNEKTING Device Library" #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Mar 11, 2022

Companion to #1178

@per1234 per1234 added topic: URL change Change library repository URL status: pending backend Depends on backend maintenance operations labels Mar 11, 2022
@umbynos umbynos self-assigned this Mar 15, 2022
@umbynos
Copy link
Contributor

umbynos commented Mar 15, 2022

Done:

2022/03/15 08:37:04 Loaded 4702 libraries from DB
Changing URL of library KONNEKTING Device Library from https://github.com/KONNEKTING/KonnektingDeviceLibrary.git to https://gitlab.com/konnekting/KonnektingDeviceLibrary.git
Success!

@umbynos umbynos added the conclusion: resolved Issue was resolved label Mar 15, 2022
@umbynos umbynos merged commit fdfb973 into arduino:production Mar 15, 2022
@per1234 per1234 deleted the move-KONNEKTING_Device_Library branch March 15, 2022 08:40
@tuxedo0801
Copy link
Contributor

tuxedo0801 commented Mar 16, 2022

@umbynos @per1234
Something's not working properly...

Log (https://downloads.arduino.cc/libraries/logs/gitlab.com/konnekting/KonnektingDeviceLibrary/) says:

2022/03/16 19:02:45 Scraping https://gitlab.com/konnekting/KonnektingDeviceLibrary.git
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA1
2022/03/16 19:02:45 Error syncing library: Error generating library from repo: can't read library.properties: open /home/ubuntu/workspace/gitclones/gitlab.com/konnekting/KonnektingDeviceLibrary/library.properties: no such file or directory
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA2
2022/03/16 19:02:45 Error syncing library: Error generating library from repo: can't read library.properties: open /home/ubuntu/workspace/gitclones/gitlab.com/konnekting/KonnektingDeviceLibrary/library.properties: no such file or directory
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA3
2022/03/16 19:02:45 Release KONNEKTING Device Library:1.0.0-BETA3 already loaded, skipping
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA4
2022/03/16 19:02:45 Release KONNEKTING Device Library:1.0.0-BETA4 already loaded, skipping
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA4a
2022/03/16 19:02:45 Release KONNEKTING Device Library:1.0.0-BETA4a already loaded, skipping
2022/03/16 19:02:45 Checking out tag: 1.0.0-BETA4b
2022/03/16 19:02:46 Release KONNEKTING Device Library:1.0.0-BETA4b already loaded, skipping

But there is another git tag "1.0.0-RC1" on gitlab (https://gitlab.com/konnekting/KonnektingDeviceLibrary/-/tags) which the sync does not see:

image

No idea what's wrong. Would be great if you can shed some light on it. Worked with previous tags like a charm...

@per1234
Copy link
Contributor Author

per1234 commented Mar 16, 2022

Hi @tuxedo0801. Thanks for your report. I will investigate this.

@per1234
Copy link
Contributor Author

per1234 commented Mar 17, 2022

I have good news for you @tuxedo0801. Thanks to your report, I found a bug I made in the tool that is used for managing these library URL change requests in the Arduino Library Manager back end.

I have submitted a fix to avoid this problem for future requests:

arduino/libraries-repository-engine#107

and @umbynos was kind enough to update the outdated data that was produced by the previous uses of the tool.

The correct Git remote URL is now used for your library and the expected release was indexed in the latest run of the job:

https://downloads.arduino.cc/libraries/logs/gitlab.com/konnekting/KonnektingDeviceLibrary/

2022/03/17 10:02:47 Checking out tag: 1.0.0-RC1

@tuxedo0801
Copy link
Contributor

Thanks a lot.

@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants