Skip to content

KONNEKTING library moved to gitlab #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

tuxedo0801
Copy link
Contributor

library moved to gitlab

library moved to gitlab
@github-actions github-actions bot added the topic: modification Change existing list entry label Mar 11, 2022
@github-actions
Copy link
Contributor

Hi @tuxedo0801.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://gitlab.com/konnekting/KonnektingDeviceLibrary:

Linting library in KonnektingDeviceLibrary
INFO: No header file found matching library name (KONNEKTING_Device_Library.h). Best practices are for primary header   
      filename to match library name. (Rule LS008)                                                                      
WARNING: library.properties name value KONNEKTING Device Library is longer than the recommended length of 16 characters.
         (Rule LP010)                                                                                                   
WARNING: library.properties name KONNEKTING Device Library contains spaces. Although supported, best practices is to not
         use spaces. (Rule LP015)                                                                                       
WARNING: Library name KONNEKTING Device Library contains "library". This is superfluous. (Rule LP016)
WARNING: Sketch(es) found outside examples and extras folders: KonnektingDeviceLibrary/test/TestSketch. See:            
         https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples (Rule LD003)              

Linter results for project: 0 ERRORS, 4 WARNINGS

-------------------

Linting sketch in KonnektingDeviceLibrary/examples/Communication_test

Linter results for project: no errors or warnings

-------------------

Linting sketch in KonnektingDeviceLibrary/examples/DemoSketch

Linter results for project: no errors or warnings

-------------------

Linting sketch in KonnektingDeviceLibrary/examples/DemoSketch_without_pins

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 4 WARNINGS

@github-actions github-actions bot requested a review from per1234 March 11, 2022 11:31
@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Mar 11, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 11, 2022

Hello @tuxedo0801. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and merges these PRs when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the topic: URL change Change library repository URL label Mar 13, 2022
@umbynos umbynos self-assigned this Mar 15, 2022
@umbynos
Copy link
Contributor

umbynos commented Mar 15, 2022

Done in #1178

@umbynos umbynos merged commit 58843f4 into arduino:main Mar 15, 2022
@umbynos umbynos added the conclusion: resolved Issue was resolved label Mar 15, 2022
@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Apr 29, 2023
@per1234 per1234 removed the topic: modification Change existing list entry label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants