Add Arduino CLI compile flags input #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This input allows the user to customize the sketch compilation process by defining arbitrary flags to be added to the `arduino-cli compile` command. In order to be as flexible as possible, the input uses a YAML list format: cli-compile-flags: | - --build-property - compiler.cpp.extra_flags="-DFOO="hello world"" -DPIN=2 - --export-binaries
A sketch was added that is designed to fail compilation if the `arduino-cli compile` command does not contain the flags specified via the input. Because the `--build-property` flag used in the test was not present in Arduino CLI 0.13.0 (the equivalent flag was `--build-properties` at that time), it was necessary to update the Arduino CLI version used by the action in the test.
|
The failure of the "Lint Python code" CI workflow run is unrelated to the change made in this PR. It will be fixed by https://github.com/per1234/compile-sketches/tree/codecov-badge The failure of the "Run integration tests" is caused by the introduction of the new test sketch. The deltas values in the golden report won't be matched until the next run when the sketch is present in the deltas base ref. |
This was referenced Apr 24, 2021
|
Had to dig out this thread to understand how to use the cli-compile-flags input. Maybe worth adding this example to the docs. |
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This input allows the user to customize the sketch compilation process by defining arbitrary flags to be added to the
arduino-cli compilecommand.In order to be as flexible as possible, the input uses a YAML list format:
Closes #16