Skip to content

Support for --build-property #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sidey79 opened this issue Dec 21, 2020 · 1 comment · Fixed by #18
Closed

Support for --build-property #16

sidey79 opened this issue Dec 21, 2020 · 1 comment · Fixed by #18
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@sidey79
Copy link

sidey79 commented Dec 21, 2020

This action is a very interesting project.

Woud like to use this and also the report size delta action, but i think there is no option to pass multiple --build-property to the compile option.
I use this, to pass defines and specify the compiler path.

May support for this options can be added, my python isn't good enough to make a pr.

@per1234 per1234 added the type: enhancement Proposed improvement label Dec 21, 2020
@per1234
Copy link
Collaborator

per1234 commented Feb 7, 2021

Hi @sidey79. Thanks for your interest in this action and for taking the time to make a feature request. I have now added the requested --build-property capability in this pull request: #18

Rather than adding a dedicated action input for defining build properties, I decided to add a general purpose input that allows the user to insert any arbitrary flags into the arduino-cli compile command used to compile the sketch. This will allow for other advanced usages (e.g., --export-binaries). I provided a usage example in the PR message.

If you want to try it out and review the PR, that would be great. The updated action from my fork can be referenced like so:

uses: per1234/compile-sketches@build-property

@per1234 per1234 self-assigned this Mar 28, 2025
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants