Quote password in signing certificate import command #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous unquoted password resulted in the command failing when the password contained shell-unfriendly characters: security: SecKeychainItemImport: MAC verification failed during PKCS12 import (wrong password?)
silvanocerza
approved these changes
Jan 8, 2021
5 tasks
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous unquoted password in the
security importcommand used to import the macOS signing certificate resulted in the command failing when the password contained shell-unfriendly characters:Example of failing import from before this change:
https://github.com/arduino/arduino-lint/runs/1660084978?check_suite_focus=true
Demonstration of successful import after this change:
https://github.com/arduino/arduino-lint/runs/1665803188?check_suite_focus=true
Downloadable here: https://downloads.arduino.cc/arduino-lint/nightly/arduino-lint_nightly-20210107_macOS_64bit.tar.gz