[skip changelog] Quote all variables in GitHub Actions workflow shell commands #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commands Unquoted variables in shell commands can result in very confusing bugs caused by unexpected interpretation of characters in the variable contents by the shell, such as globbing and word splitting. The immediate motivation for this change is that the unquoted certificate password for the macOS notarization guaranteed a someone a headache when the password wasn't so well behaved as the author of the previously fragile command had assumed: security: SecKeychainItemImport: MAC verification failed during PKCS12 import (wrong password?)
umbynos
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Bug fix
Unquoted variables in shell commands can result in very confusing bugs caused by unexpected interpretation of characters
in the variable contents by the shell, such as globbing and word splitting.
The immediate motivation for this change is that the unquoted certificate password for the macOS notarization guaranteed someone a headache when the password wasn't so well behaved as the author of the previously fragile command had assumed:
All variables used in shell command of the GitHub Actions workflows are quoted.
titled accordingly?
No breaky.
I verified the changes by running the release workflows using my macOS certificate: