Fixed path of the gen cpp and compile_flags files. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#28 has fixed the location of the `ino` file but the generated `cpp` and `compile_flags.txt` were not moved into the sketch folder. Touching the `ino` file triggered a `'textDocument/didChange'` event, but the `updateFileData` call failed as the files were not found. This commit moves the files into the appropriate location. Signed-off-by: Akos Kitta <[email protected]>
spoenemann
approved these changes
Jul 27, 2020
|
I'm going to remove |
Theia cannot handle them. Signed-off-by: Akos Kitta <[email protected]>
|
Thank you for the review, @spoenemann 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does:
#28 has fixed the location of the
inofile but the generatedcppandcompile_flags.txtwere not moved into the sketch folder.Touching the
inofile triggered a'textDocument/didChange'event,but the
updateFileDatacall failed as the files were not found.This commit moves the files into the appropriate location.
For reviewers:
It would be great to review this PR #28. Apparently, I fixed the location of the sketch file but not the
cppand thecompiler_flags.txt.Signed-off-by: Akos Kitta [email protected]