Skip to content

The LS is not compatible with the 0.11.0 CLI #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kittaakos opened this issue Jun 30, 2020 · 1 comment · Fixed by #28
Closed

The LS is not compatible with the 0.11.0 CLI #27

kittaakos opened this issue Jun 30, 2020 · 1 comment · Fixed by #28
Assignees
@kittaakos

Comments

@kittaakos
Copy link
Contributor

Problem:
The LS fails to start with the following error:
82c7c14d-be26-4101-a9c3-12aefd5df4f3

The ino file exists under this location, but the name of the sketch file does not match the name of the container folder name. The CLI throws an error here: https://github.com/arduino/arduino-cli/blob/fff99af81a922eb89c01703373659b5983375093/arduino/builder/sketch.go#L128-L131

Solution: instead of copying the files under path/to/tmp/ino2cpp-${random} we copy to path/to/tmp/ino2cpp-${random}/sketchName where sketchName is extracted from the source.
kittaakos pushed a commit that referenced this issue Jun 30, 2020
Fixed a compatibility issue with the 0.11.0 CLI.
503a272 
Made sure the `basename` of the temp folder matches with the name of the
sketch file.

Closes #27

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos self-assigned this Jun 30, 2020
@kittaakos kittaakos mentioned this issue Jun 30, 2020
Merged
kittaakos added a commit that referenced this issue Jun 30, 2020
@kittaakos
Merge pull request #28 from bcmi-labs/GH-27
1a22df3 
Fixed a compatibility issue with the `0.11.0` CLI.
@spoenemann
Copy link

We should also remove the <br>, looks like Theia no longer supports them.

@kittaakos kittaakos mentioned this issue Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed a compatibility issue with the 0.11.0 CLI. arduino/arduino-language-server
2 participants
@kittaakos @spoenemann