Check for IDE update at startup #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
reviewed
Feb 2, 2022
arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts
Outdated
Show resolved
Hide resolved
silvanocerza
reviewed
Feb 2, 2022
silvanocerza
reviewed
Feb 2, 2022
Comment on lines
87
to
88
| enum: ['latest', 'nightly', 'none'], | ||
| default: 'none', |
There was a problem hiding this comment.
none means the IDE won't check for updates?
There was a problem hiding this comment.
Right now the channel is hard-coded, but I'm about to make a change to make use of this setting to know which channel to use when checking for updates.
I think I'll change this code like this:
Suggested change
| enum: ['latest', 'nightly', 'none'], | |
| default: 'none', | |
| enum: ['latest', 'nightly'], | |
| default: 'latest', |
so that by default the user will check for the latest release. I'd remove none because it doesn't make any sense to me. Do you agree?
silvanocerza
reviewed
Feb 2, 2022
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-component.tsx
Outdated
Show resolved
Hide resolved
silvanocerza
reviewed
Feb 2, 2022
arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-component.tsx
Outdated
Show resolved
Hide resolved
…-ide into check-update-startup
# Conflicts: # arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
…-ide into check-update-startup
…te-startup # Conflicts: # browser-app/package.json # electron/build/template-package.json # electron/packager/config.js # yarn.lock
per1234
dismissed
their stale review
Suggested changes have all been resolved. I'll submit another review once the build is ready for testing.
added 10 commits
February 14, 2022 17:38
This reverts commit 5ab3a74.
…te-startup # Conflicts: # arduino-ide-extension/src/node/grpc-client-provider.ts
|
we did some internal tests and seems to be working fine. Merging to proceed with tests on the nightly build |
This was referenced Feb 20, 2022
This was referenced Feb 28, 2022
This was referenced Sep 14, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to let the user be informed when a newer version of the Arduino IDE is available, and if that is the case let them download and install it.
How
"skipIDEVersion") containing the last version they skipped