[ATL-813] Notify user when IDE new version is available #422
Conversation
|
|
AlbyIanna
force-pushed
the
atl-813--check-for-updates-via-latest-link-service
branch
from
0bc3c1d to
90d1767
Compare
AlbyIanna
force-pushed
the
atl-813--check-for-updates-via-latest-link-service
branch
2 times, most recently
from
5dd7a32 to
a2b5bb1
Compare
| @@ -48,14 +48,15 @@ | |||
| "@types/which": "^1.3.1", | |||
| "ajv": "^6.5.3", | |||
| "async-mutex": "^0.3.0", | |||
| "axios": "^0.21.1", | |||
There was a problem hiding this comment.
@AlbyIanna I love axios, but are we sure we want to add another dependency when we have something somehow similar? ("request": "^2.82.0" should be included already)
There was a problem hiding this comment.
No, you're right. I initially decided to use axios before the API was returning 403 and using request I couldn't handle the response properly, but now the API is not returning 403 anymore so I can change this.
| protected readonly messageService: MessageService; | ||
|
|
||
| async onStart(): Promise<void> { | ||
| if (await this.updatesRetriever.isUpdateAvailable()) { |
There was a problem hiding this comment.
await will block the app startup for the fetch time. It would be better to do this.updatesRetriever.isUpdateAvailable.then(available -> ). What do you think?
There was a problem hiding this comment.
@fstasi @AlbyIanna
please have a look at @kittaakos 's suggestion
per1234
added
topic: code
|
Fixes #361 |
|
@AlbyIanna can this be closed as superseded by #797? |
per1234
added
the
status: waiting for information
|
@per1234 yes , thanks. Closing 👍 |
per1234
added
conclusion: duplicate
Motivation
We need to notify the user when a new version of the IDE is available
Changes
Add a service that checks if there's a newer version than the one installed and if there is one, it shows a notification with a link to the download page.